Repository navigation
ci: stop the smoke test asserting on page copy - #36
Merged
Merged
Conversation
The title changed from "Orbital" to "Sentry Live" in #35 and the smoke test was grepping for <title>Orbital</title>, so master went red on a wording change. Assert on the mount point instead. The step's own comment says the point is "the built frontend, not a bare index" -- id="root" is exactly that, and it does not move when copy does. The bundle checks below already do the real work of proving the asset is in the image and served. Also assert that public/ survives the build into the image. Nothing covered the favicons, the manifest or the social card, so they could have stopped being copied without turning anything red. Verified against the built container: every check passes and the old assertion fails as reported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master is red after #35. My fault — I changed the page title and did not check
whether CI asserted on it.
The failure
The title is now
Sentry Live.The fix
Assert on
id="root"rather than the title. The step's own comment says thepoint is "the built frontend, not a bare index" — the mount point is that,
and it does not move when copy does. The two bundle checks below it already do
the real work of proving the named asset is in the image and served.
Swapping in the new title would have worked too, but would leave the next
wording change to break the build again.
Also added
A loop asserting
/favicon.ico,/favicon.svg,/og-v1.pngand/site.webmanifestare served. Nothing covered them, sopublic/could stopbeing copied into the image without turning anything red.
Verified
Built the image and ran the step against it: