Skip to content

ci: stop the smoke test asserting on page copy - #36

Merged
itsdangold merged 1 commit into
masterfrom
dang/fix-smoke-test
Sep 18, 2026
Merged

itsdangold merged 1 commit into
masterfrom
dang/fix-smoke-test

Conversation

@itsdangold

Copy link
Copy Markdown
Contributor

Master is red after #35. My fault — I changed the page title and did not check
whether CI asserted on it.

The failure

curl -sf http://localhost:7000/ | grep -q '<title>Orbital</title>'
→ index page missing expected content

The title is now Sentry Live.

The fix

Assert on id="root" rather than the title. The step's own comment says the
point is "the built frontend, not a bare index" — the mount point is that,
and it does not move when copy does. The two bundle checks below it already do
the real work of proving the named asset is in the image and served.

Swapping in the new title would have worked too, but would leave the next
wording change to break the build again.

Also added

A loop asserting /favicon.ico, /favicon.svg, /og-v1.png and
/site.webmanifest are served. Nothing covered them, so public/ could stop
being copied into the image without turning anything red.

Verified

Built the image and ran the step against it:

ok  /healthz
ok  /stats
ok  index is the built frontend  (new assertion)
ok  bundle /assets/index-w0mPSG5L.js
ok  /favicon.ico  (765)
ok  /favicon.svg  (3799)
ok  /og-v1.png  (245350)
ok  /site.webmanifest  (582)

title served:  <title>Sentry Live</title>
OLD assertion: FAILS  ← the red build

The title changed from "Orbital" to "Sentry Live" in #35 and the smoke test
was grepping for <title>Orbital</title>, so master went red on a wording
change.

Assert on the mount point instead. The step's own comment says the point is
"the built frontend, not a bare index" -- id="root" is exactly that, and it
does not move when copy does. The bundle checks below already do the real
work of proving the asset is in the image and served.

Also assert that public/ survives the build into the image. Nothing covered
the favicons, the manifest or the social card, so they could have stopped
being copied without turning anything red.

Verified against the built container: every check passes and the old
assertion fails as reported.
@itsdangold
itsdangold merged commit 2110db3 into master Sep 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant